Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1842 make body stored on query vars #1850

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Feature/1842 make body stored on query vars #1850

merged 3 commits into from
Oct 3, 2021

Conversation

mandaputtra
Copy link
Contributor

@mandaputtra mandaputtra commented Oct 3, 2021 •
edited by AndrewBastin

Related issue #1842. Tell me if there is any test that I should change, or provide. I'm new on testing (never done UI testing before)

fixes #1842

@netlify
Copy link

netlify bot commented Oct 3, 2021 •
edited

👷 Deploy request for hoppscotch accepted.

🔨 Explore the source changes: c387f53

🔍 Inspect the deploy log: https://app.netlify.com/sites/hoppscotch/deploys/61590cd312fa2e0008ecf253

@AndrewBastin AndrewBastin self-requested a review October 3, 2021 06:26
AndrewBastin
AndrewBastin approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Thank you for the quick PR @mandaputtra!!!! 🤗

Will merge as soon as the checks get done :)

@AndrewBastin AndrewBastin merged commit 5dcfa66 into hoppscotch:main Oct 3, 2021
@mandaputtra mandaputtra deleted the feature/1842-make-body-stored-on-query-vars branch October 3, 2021 07:39
@liyasthomas liyasthomas added hacktoberfest Hacktoberfest hacktoberfest-accepted Approved for Hacktoberfest labels Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewBastin AndrewBastin AndrewBastin approved these changes

Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Body is not stored at query vars when using "Copy link" feature
3 participants
@mandaputtra @AndrewBastin @liyasthomas