Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipart payload not working while using proxy #1864

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

cedric05
Copy link
Contributor

@cedric05 cedric05 commented Oct 9, 2021

This pull request is dependant on: checkout: hoppscotch/proxyscotch#34

@maintainer: can you add this to hacktoberfest

@netlify
Copy link

netlify bot commented Oct 9, 2021

‼️ Deploy request for hoppscotch rejected.
Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: c2d3059

SamJakob
SamJakob previously approved these changes Oct 13, 2021
Copy link
Contributor

@SamJakob SamJakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM, just up to you guys on whether you would like to use this approach really.

@AndrewBastin
Copy link
Member

I will just have a look at it today and merge it in when I get time. What about the proxy side of the implementation ? I mean, if it doesn't break anything you can merge it in @SamJakob

@SamJakob
Copy link
Contributor

SamJakob commented Oct 13, 2021

Everything good on proxy side. If you guys are happy with the way this solves the issue, I can merge straight away.

Edit: proxyscotch PR has been merged.

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedric05 please look into this.

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@AndrewBastin AndrewBastin merged commit 3f513f2 into hoppscotch:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants