-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multipart payload not working while using proxy #1864
Conversation
🔨 Explore the source changes: c2d3059 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation LGTM, just up to you guys on whether you would like to use this approach really.
I will just have a look at it today and merge it in when I get time. What about the proxy side of the implementation ? I mean, if it doesn't break anything you can merge it in @SamJakob |
Everything good on proxy side. If you guys are happy with the way this solves the issue, I can merge straight away. Edit: proxyscotch PR has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cedric05 please look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
This pull request is dependant on: checkout: hoppscotch/proxyscotch#34
@maintainer: can you add this to hacktoberfest