Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotation marks for generated code #187

Merged
merged 2 commits into from
Oct 5, 2019

Conversation

johnhenry
Copy link
Contributor

This fixes an issue where the generated code for Javascript XHR and Fetch are missing quotation marks preventing the user from easily coping and pasting the code.

@ghost
Copy link

ghost commented Oct 5, 2019

DeepCode Report (#87087c)

DeepCode analyzed this pull request.
There are no new issues.

@TravisBuddy
Copy link

Hey @johnhenry,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: ee3a5860-e728-11e9-8e12-4bc655cb216a

@liyasthomas liyasthomas self-requested a review October 5, 2019 05:18
@liyasthomas liyasthomas added bug fix This fixes a bug need testing Needs to be tested before merging onto production labels Oct 5, 2019
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 👌

@liyasthomas liyasthomas merged commit 21386b9 into hoppscotch:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix This fixes a bug need testing Needs to be tested before merging onto production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants