-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate request in collections. #1941
Conversation
👷 Deploy request for hoppscotch accepted. 🔨 Explore the source changes: a8c872d 🔍 Inspect the deploy log: https://app.netlify.com/sites/hoppscotch/deploys/618bc6ced5c1b4000795e707 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0Der great work on the PR!
But a small suggestion, while duplicating, isn't some suffix a good thing ?
For example, if I duplicate, "My Request", I don't think getting another request with the same name is nice. Something like "My Request - Duplicate" or something similar will be better.
@liyasthomas input ?
I guess renaming the duplicated request to "My request - Duplicate" is good. |
noted. working on it. |
fixed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Thank you for your PR @0xc0Der ! 🤗
related to issue #1751.