Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add undo when parameters and headers are deleted, resolves #1951 #1955

Merged

Conversation

Wils3B
Copy link
Contributor

@Wils3B Wils3B commented Nov 16, 2021

Hi everyone, I am a newcomer to this project and I want to contribute

@liyasthomas could you make a review on this pull request please

I create a toast that notify the user about the deletion with an undo button,
I used DeepL and Google Translate for text translations

Demo:

record.mp4

@netlify
Copy link

netlify bot commented Nov 16, 2021

👷 Deploy request for hoppscotch accepted.

🔨 Explore the source changes: cec26a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/hoppscotch/deploys/61937b22567dba0007b12a21

@liyasthomas
Copy link
Member

Thanks for this quick PR, will look into this as soon as possible.

@liyasthomas liyasthomas self-requested a review November 16, 2021 09:38
@liyasthomas liyasthomas self-assigned this Nov 16, 2021
liyasthomas
liyasthomas previously approved these changes Nov 16, 2021
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've made a few improvements on 2d8dd5d (#1955) to match our coding style. And removed new i18n translations instead used previously available translations.

Many thanks for this PR, and welcome to the Hoppscotch family ❤️

@Wils3B
Copy link
Contributor Author

Wils3B commented Nov 16, 2021

LGTM, I've made a few improvements on 2d8dd5d (#1955) to match our coding style. And removed new i18n translations instead used previously available translations.

Many thanks for this PR, and welcome to the Hoppscotch family heart

Thank you for your review, I'm very happy to contribute

@liyasthomas liyasthomas merged commit c651f24 into hoppscotch:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants