-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Import Insomnia collection to Hoppscotch #2031
feat: Import Insomnia collection to Hoppscotch #2031
Conversation
🔨 Explore the source changes: f47e37e |
@liyasthomas I've PRed this feature. Could you please review this PR? Please let me know if any modification needed. |
@anwarulislam I tried importing a Insomnia collection and it created a collection with an empty name. A better approach will be if all those folders were in the root itself ? Here is the Insomnia collection I tested with (as a ZIP because Github doesn't allow JSON attachments) |
@AndrewBastin I'll fix this tonight. And will update this PR. Thanks |
@AndrewBastin also, did you check that there is an error while importing postman collection. If any requests has the hostname as variable then that URL doesn't add up after importing. Please check this in production. If you found the error let me know. I'll fix this ASAP |
@anwarulislam okay noted. We are working on rewriting the entire Import/Export system as the codebase is really old and to be honest really sucks, we are just waiting for this PR to be merged in so we can start the refactor. |
@AndrewBastin I've fixed the collection name issue of Insomnia. Now, you can import the collection from Insomnia and you will see the name. If no name found then it will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewBastin Thanks for the review. No nothing else in this branch. You can merge it if it's good to go :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc: @AndrewBastin
Closes #
Description
I have added a feature to import the Insomnia collection to Hoppscotch. When a user selects Import from JSON I'm checking that is this collection from Insomnia or not. if it's from insomnia then I'm parsing the JSON and transforming it to Postman collection. The parsing script in helpers/utils directory. And the import is working as regular.
Checks
Additional Information