Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure Method In Endpoint #2083

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

RishabhAgarwal-2001
Copy link
Contributor

Closes #2058

Description

While sending a HTTP request without a specified method, the method is determined using domain name and appended to the request. Following is the way of determining the request method -

  • If domain name is either localhost or period delimited numbers (eg. 127.0.0.1 or any IP address), HTTP protocol is used
  • In all other cases HTTPS protocol is used

The updated endpoint is reflected in the URL input box.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@netlify
Copy link

netlify bot commented Jan 24, 2022

‼️ Deploy request for hoppscotch rejected.
Learn more about Netlify's sensitive variable policy

🔨 Explore the source changes: 20bfd16

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: explicit UI for protocol (e.g. http / https)
2 participants