feat: handle test script execution failure #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Explore the source changes: ad04ab2 |
AndrewBastin
requested changes
Jan 31, 2022
liyasthomas
approved these changes
Feb 1, 2022
devblin
pushed a commit
to devblin/hoppscotch
that referenced
this pull request
Feb 4, 2022
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
kyteinsky
pushed a commit
to kyteinsky/hoppscotch
that referenced
this pull request
Feb 9, 2022
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2079
Description
Existing code didn't handle the case when execution of test script was not successful. In case of a faulty test/post-request script, the users were greeted with the results of the latest valid test script.
With this PR, the case of script execution failure is now covered. Users will see an error message instead of old test results.
Checks
Additional Information
N/A