Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor code refactor #214

Merged
merged 1 commit into from
Oct 25, 2019
Merged

chore: minor code refactor #214

merged 1 commit into from
Oct 25, 2019

Conversation

jamesgeorge007
Copy link
Member

Array destructuring makes the respective code snippet much concise.

@ghost
Copy link

ghost commented Oct 25, 2019

DeepCode Report (#55dfb1)

DeepCode analyzed this pull request.
There are no new issues.

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 1fb47460-f738-11e9-bdcb-879e987f4e2b

NBTX
NBTX approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@NBTX NBTX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer! I think destruction is one of the awesome features I don't use enough.

@NBTX NBTX merged commit 2ac8a45 into hoppscotch:master Oct 25, 2019
@jamesgeorge007 jamesgeorge007 deleted the feat/minor-refactor branch October 26, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NBTX NBTX NBTX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesgeorge007 @TravisBuddy @NBTX