Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_url should be project directory #22

Merged
merged 1 commit into from
Aug 23, 2019
Merged

start_url should be project directory #22

merged 1 commit into from
Aug 23, 2019

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Aug 23, 2019

Otherwise it will install https://liyasthomas.github.io/.

@TravisBuddy
Copy link

Hey @abraham,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: facfff40-c558-11e9-8712-75d78f9b457f

@TravisBuddy
Copy link

Hey @abraham,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: fb259950-c558-11e9-8712-75d78f9b457f

@liyasthomas liyasthomas merged commit 5adbd95 into hoppscotch:master Aug 23, 2019
@liyasthomas liyasthomas mentioned this pull request Aug 23, 2019
AndrewBastin pushed a commit that referenced this pull request Apr 11, 2023
…seudo-fp format (#22)

* refactor: refactor all queries,mutations and subscriptions for shortcode module

* test: rewrote test cases for shortcodes

* chore: modified shortcode error code

* chore: created helper function to do shortcode type conversion in service file

* chore: simplifed logic to fetch user shortcodes with cursor pagination

* chore: removed migrations file

* chore: removed unused imports in shortcodes module

* chore: modified generateUniqueShortCodeID function

* chore: modified generateUniqueShortCodeID function

* chore: changed jwtService to use verify instead of decode

* docs: added teacher comments to all shortcodes service methods

* chore: removed stale test cases from shortcode modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants