Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent IMEs from triggering when editing a readonly code editor #2222

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

AndrewBastin
Copy link
Member

This small patch introduces a small update that blocks IMEs from starting composition when editing a readonly code editor instance.

This is especially useful on mobile devices where the virtual keyboard is triggered when the REST Response Body is tapped on which further reduces the screen space.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Check IME behavior on Android and iOS and see how they react on readonly and readwrite fields.

@AndrewBastin AndrewBastin self-assigned this Apr 1, 2022
@AndrewBastin AndrewBastin merged commit f027d2d into hoppscotch:main Apr 1, 2022
@AndrewBastin AndrewBastin deleted the fix/cm-readonly-ime branch April 1, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant