Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added execution duration and updated collection-metrics #2257

Merged
merged 3 commits into from
Apr 18, 2022
Merged

feat: added execution duration and updated collection-metrics #2257

merged 3 commits into from
Apr 18, 2022

Conversation

devblin
Copy link
Contributor

@devblin devblin commented Apr 12, 2022

Description

The PR includes features mentioned below.

  • Each request's execution duration in seconds.
  • Each test-script's execution duration in seconds.
  • Total execution duration for all requests and test-scripts respectively.
  • Total passing and failing requests, test-scripts, pre-request-scripts.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

@netlify
Copy link

netlify bot commented Apr 12, 2022 •
edited

‼️ Deploy request for hoppscotch rejected.

Name Link
🔨 Latest commit dc4c71c

@AndrewBastin AndrewBastin self-requested a review April 13, 2022 00:34
AndrewBastin
AndrewBastin requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff.

packages/hoppscotch-cli/src/utils/collections.ts Outdated Show resolved Hide resolved
packages/hoppscotch-cli/src/utils/collections.ts Show resolved Hide resolved
packages/hoppscotch-cli/src/utils/display.ts Show resolved Hide resolved
packages/hoppscotch-cli/src/utils/display.ts Outdated Show resolved Hide resolved
packages/hoppscotch-cli/src/utils/display.ts Outdated Show resolved Hide resolved
packages/hoppscotch-cli/src/utils/getters.ts Outdated Show resolved Hide resolved
packages/hoppscotch-cli/src/utils/getters.ts Outdated Show resolved Hide resolved
packages/hoppscotch-cli/src/utils/request.ts Outdated Show resolved Hide resolved
packages/hoppscotch-cli/src/types/response.ts Outdated Show resolved Hide resolved
@devblin devblin force-pushed the feat/hopp-cli-duration branch 2 times, most recently from ace23de to 45acf66 Compare April 16, 2022 10:55
@AndrewBastin AndrewBastin self-requested a review April 18, 2022 12:45
AndrewBastin
AndrewBastin approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@AndrewBastin AndrewBastin merged commit 06937fe into hoppscotch:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewBastin AndrewBastin AndrewBastin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devblin @AndrewBastin