-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: loading states for modal buttons #2268
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💯
ask and wait for @liyasthomas to know whether we should do anything about the Delete option.
Although, I would think it will not hurt to do that.
@kyteinsky it would be great if we can introduce loading state in delete confirmation modals too. Mainly the delete request, delete collection, delete folder prompts on teams. |
@liyasthomas There are two ways to add loading in delete confirmation modals, one by introducing an optional prop in |
Introduce a prop in |
Should I change the Folder delete logic in the respective files |
@kyteinsky you can maintain whatever way it is right now and not worry about where the logic is (although, all of them should be in index.vue). We are planning a major rewrite of the collection tree structure and we will clear most of it during that time. |
9a7dad0
to
af0036e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💯
af0036e
to
0f0cf31
Compare
Description
Adds loading state to buttons in different modals.