Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UI of shortcode actions #2347

Merged
merged 20 commits into from
May 24, 2022
Merged

feat: UI of shortcode actions #2347

merged 20 commits into from
May 24, 2022

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented May 19, 2022 •
edited

Description

This PR introduces a feature in which authenticated user can view their created shortcodes and can delete, copy shortcode link or open the request from their profile page.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@nivedin nivedin marked this pull request as ready for review May 19, 2022 17:42
@AndrewBastin AndrewBastin requested review from liyasthomas and AndrewBastin and removed request for liyasthomas May 20, 2022 07:03
AndrewBastin
AndrewBastin requested changes May 20, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on call.

@nivedin nivedin requested a review from AndrewBastin May 20, 2022 17:01
@liyasthomas
Copy link
Member

@nivedin

  1. We should provide a loading state, a spinner while fetching the remaining entries in the list (intersection observer action).

  2. Limit the table's height to a convenient fixed height (~360px). Let the entries overflow within the table's body.

AndrewBastin
AndrewBastin requested changes May 23, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the call

@nivedin nivedin requested a review from AndrewBastin May 24, 2022 10:36
liyasthomas
liyasthomas previously approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

AndrewBastin
AndrewBastin previously approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@liyasthomas liyasthomas changed the title feat : UI implementation of Shortcode feat: UI of shortcode actions May 24, 2022
@liyasthomas liyasthomas merged commit cfa89a6 into hoppscotch:main May 24, 2022
liyasthomas added a commit that referenced this pull request Jun 16, 2022
@nivedin @liyasthomas @AndrewBastin
feat: UI of shortcode actions (#2347)
19892b1 
Co-authored-by: liyasthomas <liyascthomas@gmail.com>
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

@AndrewBastin AndrewBastin AndrewBastin left review comments

Assignees

@nivedin nivedin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nivedin @liyasthomas @AndrewBastin