Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Copy and download filtered response body #2426

Merged
merged 2 commits into from
Jun 16, 2022
Merged

fix: Copy and download filtered response body #2426

merged 2 commits into from
Jun 16, 2022

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Jun 13, 2022 •
edited

Description

Currently, the initial response body gets copied and downloaded after filtering, this PR fixes this bug.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@nivedin nivedin requested a review from liyasthomas June 13, 2022 14:47
@liyasthomas liyasthomas self-assigned this Jun 16, 2022
@liyasthomas liyasthomas force-pushed the fix/copy-download-filtered-responseBody branch from 3b5479e to 34b4133 Compare June 16, 2022 00:37
liyasthomas
liyasthomas approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@liyasthomas liyasthomas merged commit 185dc3f into hoppscotch:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

Assignees

@liyasthomas liyasthomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nivedin @liyasthomas