fix: resolve removing body parameters in requests (#2390) #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the PR @vaugenwake! ❤️ I made a small change of instead of adding id to the FormDataKeyValue object, I changed working params to contain an object wrapping the keyvalue thingy. This removes some of the TypeScript issues. Can you just verify once again from your end that this implementation works ? I think I did cover all the cases, just asking to be sure. |
AndrewBastin
force-pushed
the
fix-remove-body-parameter
branch
from
2a16a27
to
dd66a23
Compare
|
@AndrewBastin Yeah all looks good from my tests |
|
wokey. looks good at my end too. merging. once again, thank you for the PR @vaugenwake! nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2390
Description
This PR resolves an issue with removing a parameters for request body parameters causing the browser to crash and hang. The solution to this is to add an
idparameter to parameters so that each item is unique in the view and gets re-rendered on change.[x] Fixed removing a body parameter from REST Request
Checks
Additional Information