Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove confirm change popup and add ability to overwrite request in saveas popup #2433

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Jun 17, 2022

Closes #2368

Description

This PR closes the issue where a user could not overwrite a request and remove the confirm change popup inside the save as popup.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@AndrewBastin AndrewBastin merged commit c8dec56 into hoppscotch:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: can't save as to another request
2 participants