Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: environment variables save without pressing 'save' button #2454

Merged
merged 5 commits into from
Jun 30, 2022
Merged

fix: environment variables save without pressing 'save' button #2454

merged 5 commits into from
Jun 30, 2022

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Jun 23, 2022

Closes #2436

Description

This PR fixes a bug that saved the environment variables without pressing the 'save' button.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@nivedin nivedin marked this pull request as ready for review June 27, 2022 17:11
AndrewBastin
AndrewBastin approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@AndrewBastin AndrewBastin merged commit c34185d into hoppscotch:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewBastin AndrewBastin AndrewBastin approved these changes

@liyasthomas liyasthomas Awaiting requested review from liyasthomas liyasthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: environment variables are eager to save without pressing 'save' button
2 participants
@nivedin @AndrewBastin