feat: remember pane sizes #2556
Conversation
There was a problem hiding this comment.
We're using this AppPaneLayout for many pages. And we should remember pane sizes for every page separately. Your implementation is just remembering globally. So, whenever we change pane size it affects all the pages wherever we use the PaneLayout.
Instead of doing it globally we can get the layout-id as prop from the parent component. And use that prop as a prefix to define keys. Also, don't use localStorage directly to the component. We already have the implementation to store values in localpersistence.ts file. You can use that function to store.
sagar290
force-pushed
the
feat/remember-pane-size
branch
2 times, most recently
from
879a01d
to
f6f3f38
Compare
sagar290
force-pushed
the
feat/remember-pane-size
branch
from
27f435e
to
6b12660
Compare
|
@AndrewBastin, it seems okay to me. |
There was a problem hiding this comment.
Just minor variable naming scheme corrections.
Also, this is only implemented for documentation.vue as of right now, other pages should also implement this thing.
(note to reviewer: @anwarulislam make sure you check variable naming schemes on your reviews as well)
Noted! |
sagar290
force-pushed
the
feat/remember-pane-size
branch
from
bb2d0d8
to
de7d30d
Compare
There was a problem hiding this comment.
lgtm 💯
@liyasthomas a final round of checks and you can merge it in.
Closes #2456
Description
Save the different pane sizes (for instance, in local storage) in order to restore the visual configuration the next time the app is opened
Checks
Additional Information