Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hightlight environment variable with a dash '-' in its name #2560

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Hightlight environment variable with a dash '-' in its name #2560

merged 1 commit into from
Aug 8, 2022

Conversation

anwarulislam
Copy link
Member

@anwarulislam anwarulislam commented Aug 6, 2022 •
edited

Closes #2554

Description

The issue is when having an environment variable with a dash '-' in its name, the variable is not colorized in the URL. It's fixed by this PR.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

liyasthomas
liyasthomas approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@liyasthomas liyasthomas merged commit a9e1a30 into hoppscotch:main Aug 8, 2022
@anwarulislam anwarulislam self-assigned this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin AndrewBastin is a code owner

Assignees

@anwarulislam anwarulislam

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@anwarulislam @liyasthomas