Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added token based authentication type #28

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Added token based authentication type #28

merged 1 commit into from
Aug 23, 2019

Conversation

reefqi037
Copy link
Contributor

User can choose Bearer Token authentication type to access apis protected with access/id token.

@reefqi037
Added token based authentication type
3c4cb60 
User can choose Bearer Token authentication type to access apis protected with access/id token.
@TravisBuddy
Copy link

Hey @reefqi037,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: be2fbf40-c570-11e9-8712-75d78f9b457f

@TravisBuddy
Copy link

Hey @reefqi037,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c0bf91e0-c570-11e9-8712-75d78f9b457f

liyasthomas
liyasthomas approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Have you tested it?

@liyasthomas liyasthomas added feature New feature or request need testing Needs to be tested before merging onto production labels Aug 23, 2019
@reefqi037
Copy link
Contributor Author

Yes. I've tested it on my own AWS Api Gateway endpoint configured with Cognito Authorizer.

Bearer Token test

@liyasthomas
Copy link
Member

Thanks for the quick reply 💜

@liyasthomas liyasthomas merged commit 417aeff into hoppscotch:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

Assignees
No one assigned
Labels
feature New feature or request need testing Needs to be tested before merging onto production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reefqi037 @TravisBuddy @liyasthomas