-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: selected env changed while sidebar collapsed #3002
Merged
AndrewBastin
merged 5 commits into
hoppscotch:main
from
nivedin:fix/env-change-sidebar-collapse
Apr 21, 2023
Merged
fix: selected env changed while sidebar collapsed #3002
AndrewBastin
merged 5 commits into
hoppscotch:main
from
nivedin:fix/env-change-sidebar-collapse
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewBastin
requested changes
Apr 18, 2023
nivedin
force-pushed
the
fix/env-change-sidebar-collapse
branch
from
April 18, 2023 18:18
ab80757
to
24fbd1a
Compare
amk-dev
reviewed
Apr 19, 2023
amk-dev
reviewed
Apr 19, 2023
amk-dev
requested changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look into the comments
amk-dev
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
AndrewBastin
force-pushed
the
fix/env-change-sidebar-collapse
branch
from
April 21, 2023 14:51
e572dca
to
6d0e27e
Compare
AndrewBastin
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2995
Description
This PR resolves the problem where, when a user selects a team environment and toggles the sidebar, the selected environment is reset.
Checks