Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selected env changed while sidebar collapsed #3002

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Apr 18, 2023

Closes #2995

Description

This PR resolves the problem where, when a user selects a team environment and toggles the sidebar, the selected environment is reset.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link
Contributor

@amk-dev amk-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look into the comments

@nivedin nivedin requested a review from amk-dev April 19, 2023 11:19
Copy link
Contributor

@amk-dev amk-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AndrewBastin AndrewBastin force-pushed the fix/env-change-sidebar-collapse branch from e572dca to 6d0e27e Compare April 21, 2023 14:51
@AndrewBastin AndrewBastin merged commit 3506e96 into hoppscotch:main Apr 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: when you close the sidebar and open it again, if you have env selected, it resets
3 participants