fix: wrong tab selected after navigating from different route #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwarulislam
force-pushed
the
fix/selected-tab-incremental-issue
branch
from
af65dee
to
891a3e6
Compare
AndrewBastin
force-pushed
the
fix/selected-tab-incremental-issue
branch
from
891a3e6
to
54925d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: If multiple tabs are opened, and the first tab is selected. after going to another page from the REST page and then coming back to REST, the selection goes to the next tab.
Previously, we were forcefully selecting the first possible
Windowforcefully after removing any activeWindow. And it was happeningonBeforeUnmounted. But, now it will select the lastWindowautomatically.Checks