fix: graphql page crashing and broken syntax highlighting #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amk-dev
changed the title
|
@amk-dev I think we can remove |
Ohh, we can do that then. i think there are also other packages that are not used in there. we can remove them also. but may be on a seprate PR. |
amk-dev
force-pushed
the
fix/graphql-crashing
branch
from
89fa867
to
f98687d
Compare
AndrewBastin
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Our graphql page was crashing and syntax highlighting was not working properly. The error was due to having multiple versions of
@lezer/highlightpackage being installed.hoppscotch-uiuses^1.0.0andhoppscotch-commonuses^1.1.6After
We can fix the problem by bumping
@lezer/highlightto1.1.6, but since@lezer/highlightis an unused dependency inhoppscotch-ui, we decided to remove it.