feat: press tab on current input field to focus the next input field #3754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anwarulislam
force-pushed
the
feat/tab-to-focus-next-field
branch
from
1b6787f
to
de96e9f
Compare
JoelJacobStephen
approved these changes
Jan 17, 2024
anwarulislam
force-pushed
the
feat/tab-to-focus-next-field
branch
from
de96e9f
to
df86e9d
Compare
JoelJacobStephen
approved these changes
Jan 17, 2024
AndrewBastin
changed the base branch from
release/2023.12.2
to
release/2023.12.3
AndrewBastin
force-pushed
the
feat/tab-to-focus-next-field
branch
from
3598de2
to
6b63b64
Compare
1 task
JoelJacobStephen
pushed a commit
to JoelJacobStephen/hoppscotch
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HFE-385
Description
This PR modifies the keyboard event handling in the
EnvInput.vuecomponent.Tabwill focus the next input field for better accessibilityenterevent was emitted to hide suggestions popover and run request at the same time whileTabwas used to select and hide suggestions popover. Now,Tabwill do its default behavior.Enterwill select the suggestion from the suggestions list and emit the event to run the request when the suggestions popover is not opened.Status