fix(sh-admin): persist active selection in the sidebar #3812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewBastin
approved these changes
Feb 8, 2024
AndrewBastin
force-pushed
the
hotfix/sh-admin-sidebar-active-selection
branch
from
321a04d
to
d72c060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures the active selection in the sidebar for the Admin dashboard is persisted across page reloads. A new property,
baseRouteNameis introduced underprimaryNavigationsin theAppSidebarcomponent that defines the base route names corresponding to each nav item and checks against the route name to decide whether to apply the classes for active selection or not.Closes HFE-424.
Preview
recording.mov
Checks