New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sh-admin): introducing data analytics and newsletter configurations #3845
feat(sh-admin): introducing data analytics and newsletter configurations #3845
Conversation
fc9c7bb
to
f38e2b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was getting CORS error while enabling the newsletter option, is this a known issue @JoelJacobStephen
packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
@nivedin I set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/setup/DataSharingAndNewsletter.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-sh-admin/src/components/settings/DataSharing.vue
Outdated
Show resolved
Hide resolved
7876c5c
to
c32691f
Compare
…ler and server restart
…essary route guard checks
- Parse errors correctly from the query response. - Locale entry updates.
33f0638
to
e3ad680
Compare
Ticket
Description
This PR introduces data analytics and newsletter support to the Admin Dashboard. When a new user instantiates the admin dashboard, a new data sharing page will be displayed on first initialisation which asks admins if they are interested in sharing data to make Hoppscotch better and are willing to signup to the newsletter. Admins can also modify these choices in under Configurations tab in the Settings Panel of the Dashboard
Screenshot
Checks