Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sh-admin): introducing data analytics and newsletter configurations #3845

Conversation

JoelJacobStephen
Copy link
Contributor

@JoelJacobStephen JoelJacobStephen commented Feb 20, 2024

Ticket

Description

This PR introduces data analytics and newsletter support to the Admin Dashboard. When a new user instantiates the admin dashboard, a new data sharing page will be displayed on first initialisation which asks admins if they are interested in sharing data to make Hoppscotch better and are willing to signup to the newsletter. Admins can also modify these choices in under Configurations tab in the Settings Panel of the Dashboard

Screenshot

image

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@JoelJacobStephen JoelJacobStephen force-pushed the feat/dashboard-data-usage branch 2 times, most recently from fc9c7bb to f38e2b6 Compare February 27, 2024 11:39
@JoelJacobStephen JoelJacobStephen marked this pull request as ready for review February 27, 2024 13:08
@JoelJacobStephen JoelJacobStephen changed the title feat: introducing data analytics and newsletter configurations in admin dashboard feat(sh-admin): introducing data analytics and newsletter configurations Feb 27, 2024
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was getting CORS error while enabling the newsletter option, is this a known issue @JoelJacobStephen

image

@JoelJacobStephen
Copy link
Contributor Author

was getting CORS error while enabling the newsletter option, is this a known issue @JoelJacobStephen

image

@nivedin I set the withCredentials property to false and now it works perfectly. You can crosscheck once more.

Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

JoelJacobStephen and others added 21 commits March 6, 2024 18:12
- Parse errors correctly from the query response.
- Locale entry updates.
@AndrewBastin AndrewBastin merged commit 919579b into hoppscotch:release/2024.3.0 Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants