Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added mutation and function to platform for updating user profile name #3929

Merged
merged 9 commits into from Mar 25, 2024
Merged

feat: added mutation and function to platform for updating user profile name #3929

merged 9 commits into from Mar 25, 2024

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Mar 22, 2024 •
edited

Closes HFE-455

Description

This PR adds the mutation and function to the platform to update user profile name from the profile section.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@nivedin nivedin requested a review from amk-dev as a code owner March 22, 2024 11:28
@anwarulislam anwarulislam self-requested a review March 25, 2024 05:56
@nivedin nivedin requested a review from amk-dev March 25, 2024 06:24
@nivedin nivedin force-pushed the feat/update-user-display-name branch from 7c7eacb to 7e1b1f8 Compare March 25, 2024 06:57
jamesgeorge007
jamesgeorge007 reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A potential enhancement we could have here is ensuring the GQL mutation gets triggered only when there's a change detected in the profile name.

@jamesgeorge007 jamesgeorge007 merged commit c326f54 into release/2024.3.0 Mar 25, 2024
1 check passed
@jamesgeorge007 jamesgeorge007 deleted the feat/update-user-display-name branch March 25, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@anwarulislam anwarulislam anwarulislam approved these changes

@amk-dev amk-dev amk-dev approved these changes

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin AndrewBastin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nivedin @jamesgeorge007 @anwarulislam @amk-dev