refactor: switch workspace after creation #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelJacobStephen
requested changes
Apr 30, 2024
There was a problem hiding this comment.
@nivedin When a new workspace is created, the dropdown which allows users to switch workspaces is not updated. Even after switching to the personal workspace, it is not updated.
Screen.Recording.2024-04-30.at.10.49.14.AM.mov
nivedin
force-pushed
the
refactor/workspace-switch-after-creation
branch
from
4b37c2d
to
056f21b
Compare
JoelJacobStephen
requested changes
May 7, 2024
packages/hoppscotch-common/src/components/environments/index.vue
Outdated
Show resolved
Hide resolved
nivedin
force-pushed
the
refactor/workspace-switch-after-creation
branch
from
056f21b
to
010266f
Compare
amk-dev
reviewed
May 8, 2024
| if (team) { | ||
| collectionsType.value.type = "team-collections" | ||
| teamCollectionAdapter.changeTeamID(team.teamID) |
There was a problem hiding this comment.
Ideally we need all the changes that happens when a new team is selected to go into one place.
its okey for now. we might update it in the new workspace system.
AndrewBastin
force-pushed
the
refactor/workspace-switch-after-creation
branch
from
d939f87
to
7f64a74
Compare
jobartim44
pushed a commit
to jobartim44/hoppscotch-switch-workspace
that referenced
this pull request
May 15, 2024
Co-authored-by: amk-dev <akash.k.mohan98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HFE-483
Description
This PR add's a improvement in the workspace creation flow where the workspace is automatically switched to the created one.
Checks