Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added codegen tab in the sidbear #4099

Merged
merged 8 commits into from
Jun 24, 2024
Merged

feat: added codegen tab in the sidbear #4099

merged 8 commits into from
Jun 24, 2024

Conversation

anwarulislam
Copy link
Member

@anwarulislam anwarulislam commented Jun 3, 2024 •
edited
Loading

Closes HFE-493

Description

This change addresses issue HFE-493 by making code geneation tools readily available through the sidebar.

  • Not Completed
  • Completed

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@nivedin nivedin self-requested a review June 3, 2024 09:06
nivedin
nivedin requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

we can add a padding top, remove the border-radius and left-right-border for the HttpCodegen component

  • also we have to watch the tab state because the code generation is not updating
Screen.Recording.2024-06-04.at.1.25.57.PM.mov

@anwarulislam anwarulislam requested a review from nivedin June 4, 2024 09:48
nivedin
nivedin approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@nivedin nivedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AndrewBastin AndrewBastin changed the base branch from main to next June 24, 2024 06:17
@AndrewBastin AndrewBastin merged commit 9d02c8e into hoppscotch:next Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivedin nivedin nivedin approved these changes

@amk-dev amk-dev Awaiting requested review from amk-dev

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anwarulislam @nivedin @AndrewBastin