Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL query validation based on schema #508

Merged

Conversation

AndrewBastin
Copy link
Member

@AndrewBastin AndrewBastin commented Jan 19, 2020

This PR intends to introduce Query Validation based on schema. Therefore, errors on the query (as long as there are no syntax errors) are reported by evaluating with the schema, this helps catch undefined schema field accessing.

#468

@AndrewBastin AndrewBastin added the feature New feature or request label Jan 19, 2020
@AndrewBastin AndrewBastin added this to the v2.0 milestone Jan 19, 2020
@AndrewBastin AndrewBastin self-assigned this Jan 19, 2020
@ghost
Copy link

ghost commented Jan 19, 2020

DeepCode's analysis on #744d64 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8ac22800-3af5-11ea-99a0-cda489651399

@AndrewBastin AndrewBastin merged commit cd26801 into hoppscotch:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants