Response status colors added. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @izerozlu, TravisBuddy Request Identifier: 9a4df870-c6a7-11e9-be9f-2924d72427a9 |
|
Hey @izerozlu, TravisBuddy Request Identifier: bef8df50-c6a7-11e9-be9f-2924d72427a9 |
|
I like that you used regexes for each of the status code groups! |
|
Looks cool, exactly it should've been. 🔥 Would you mind creating a PR to bind the colored class to history entries status codes too..? That would be great! |
|
Sure. Will create a PR for entries as well soon. |
AndrewBastin
pushed a commit
that referenced
this pull request
Apr 11, 2023
* fix: check if admin users are there in infra when removing user as an admin * fix: corrected the logic for length check * chore: update error message * chore: add new error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #46 's request is fullfilled by adding a computed property to check after
responsechanges to determine which category is theresponse.Categories are implemented from Http Status Code.