Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃帹 Add theme support (and settings storage) #55

Merged
merged 8 commits into from Aug 25, 2019
Merged

馃帹 Add theme support (and settings storage) #55

merged 8 commits into from Aug 25, 2019

Conversation

NBTX
Copy link
Contributor

@NBTX NBTX commented Aug 25, 2019

image

image

image

This PR adds support for background theme selection and accent color selection. Additional background/accent colors can be easily defined the application. (Refer to /layouts/settings.vue for guidance.)

Here's a full list of what this PR achieves:

  • Move root (var) style properties to /assets/css/themes.scss

  • Improve mobile navigation

  • Create section component for the collapsable sections.

  • Create logo component, so color can be changed.

  • Add settings page

  • Add option to select theme color

  • Add option to select theme background

  • Add option to enable/disable multi-colored frames.

  • Add settings to VueX Store

  • Persist VueX store in LocalStorage.

This PR also:

SamJakob and others added 6 commits August 24, 2019 18:26
- Move root (var) style properties to `/assets/css/themes.scss`
- Improve mobile navigation
- Create section component for the collapsable sections.
- Create logo component, so color can be changed.

- Add settings page
- Add option to select theme color
- Add option to select theme background
- Add option to enable/disable multi-colored frames.

- Add settings to VueX Store
- Persist VueX store in LocalStorage.
@NBTX
Copy link
Contributor Author

NBTX commented Aug 25, 2019

As with the other PRs, you can try out the changes on my GitHub Pages instance:
https://nbtx.github.io/postwoman-vue/

@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d1746e00-c6cb-11e9-be9f-2924d72427a9

@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d36fc8d0-c6cb-11e9-be9f-2924d72427a9

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and pull, I got minor conflicts in style.scss and index.vue

@liyasthomas liyasthomas added the feature New feature or request label Aug 25, 2019
@NBTX
Copy link
Contributor Author

NBTX commented Aug 25, 2019

Okay

@NBTX
Copy link
Contributor Author

NBTX commented Aug 25, 2019

Rebased and merged.

@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bd32b290-c6d9-11e9-be9f-2924d72427a9

@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c066db80-c6d9-11e9-be9f-2924d72427a9

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@liyasthomas liyasthomas merged commit 8a6ec09 into hoppscotch:master Aug 25, 2019
@liyasthomas
Copy link
Member

@NBTX Send button on HTTP tabs isn't working.

This was referenced Aug 25, 2019
@liyasthomas
Copy link
Member

Found what's causing the error #58

AndrewBastin pushed a commit that referenced this pull request Apr 11, 2023
* fix: added reqType typed in sdl

* fix: updateUserSession type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants