Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added create collection and save request syncs #568

Merged
merged 2 commits into from Feb 13, 2020

Conversation

JacobAnavisca
Copy link
Contributor

Heyo! I was having issues syncing collections/requests and realized syncing only seems to work if you create and then edit collections. I just added the sync method to the add collection and save request components. There might be a better way to do it then how I've done it.

@ghost
Copy link

ghost commented Feb 13, 2020

DeepCode's analysis on #516610 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @JacobAnavisca,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 803a5280-4e1f-11ea-b00e-d175f66e4ddd

@TravisBuddy
Copy link

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0b2f56f0-4e30-11ea-b00e-d175f66e4ddd

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JacobAnavisca forgot to invoke this.syncCollections(); in components/collections/saveRequestAs.vue . No problem, fixed it 👍

@liyasthomas liyasthomas self-assigned this Feb 13, 2020
@TravisBuddy
Copy link

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 592baae0-4e47-11ea-b00e-d175f66e4ddd

@liyasthomas liyasthomas merged commit 9a06b19 into master Feb 13, 2020
@liyasthomas liyasthomas deleted the fix/collection-sync branch February 13, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants