Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation for URL #7

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Conversation

AndrewBastin
Copy link
Member

@AndrewBastin AndrewBastin commented Aug 22, 2019

Well, I have implemented some styling and functionality for URL validation.

To see it in action, just put in an invalid URL

If there are any Vue mistakes, please forgive, as I am a React person actually...

Also, I have added an alert popup when the Send button is clicked with an invalid URL, I am not a big fan of that, if you would like to, you could update that with something more cleaner...

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 81e1b6d0-c4ec-11e9-8712-75d78f9b457f

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 82400370-c4ec-11e9-8712-75d78f9b457f

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 🙌

@liyasthomas liyasthomas merged commit 1a02837 into hoppscotch:master Aug 22, 2019
liyasthomas pushed a commit that referenced this pull request Feb 25, 2021
AndrewBastin pushed a commit that referenced this pull request Apr 11, 2023
feat: introduce user history in self hosted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants