Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for legacy extensions #747

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Remove support for legacy extensions #747

merged 1 commit into from
Apr 8, 2020

Conversation

levrik
Copy link
Contributor

@levrik levrik commented Apr 8, 2020

I think enough time has passed so we can remove support for these from Postwoman now.

@ghost
Copy link

ghost commented Apr 8, 2020

Congratulations 🎉. DeepCode analyzed your code in 1.108 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@TravisBuddy
Copy link

Hey @levrik,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 02acf460-7982-11ea-9e83-b31d17657a6d

@TravisBuddy
Copy link

Hey @levrik,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c349e250-7982-11ea-9e83-b31d17657a6d

@AndrewBastin
Copy link
Member

Lol, I was planning on doing this myself yesterday. Thanks for doing this 😄

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewBastin AndrewBastin merged commit ac78750 into hoppscotch:master Apr 8, 2020
@levrik levrik deleted the remove-legacy-extension-strategies branch April 8, 2020 17:02
@levrik
Copy link
Contributor Author

levrik commented Apr 8, 2020

@AndrewBastin Haha, I'm sorry. Actually I saw that leftover code yesterday when I pushed the fix for getting the GraphQL schema via extensions and planned to remove it in the evening. Didn't get to it and did it today then 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants