Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postman import with empty url #791

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

Nikita240
Copy link
Contributor

If you try importing a postman collection that contains an empty raw url, it silently fails.

Just needed a nullcheck.

@TravisBuddy
Copy link

Hey @Nikita240,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b33913b0-82c2-11ea-a3c8-5be21eefecce

@Nikita240
Copy link
Contributor Author

Here's a sample json to test:

{
	"info": {
		"_postman_id": "f695cab7-6878-eb55-7943-ad88e1ccfd65",
		"name": "Test",
		"schema": "https://schema.getpostman.com/json/collection/v2.1.0/collection.json"
	},
	"item": [
		{
			"name": "Test",
			"request": {
				"method": "GET",
				"header": [],
				"url": {
					"raw": ""
				}
			},
			"response": []
		}
	]
}

@liyasthomas liyasthomas merged commit 780e80a into hoppscotch:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants