Realtime SocketIO support for json user input #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perly emit json data. Falls back to string input
|
Hey @feydan, TravisBuddy Request Identifier: 5b9b1440-898f-11ea-aae4-d3259c3e8c73 |
feydan
changed the title
liyasthomas
approved these changes
Apr 28, 2020
|
@feydan Thank you for the quick PR, it's a nice enhancement. |
|
Thank you for the lightning fast response! |
|
Hey, @feydan It doesn't seem to work for me. |
|
Hi @whyDontI . It is hard to know if you are missing something without additional context. Are you using the SocketIO tab? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SocketIo tab in realtime currently only supports string input even though the SocketIo library can support sending json data (implicitly encoding and decoding).
This change attempts to parse the user input to json in order to send it as json instead of a string. If the user input is not valid json, it will be sent as a string.