Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(store): better code structure #835

Merged
merged 2 commits into from
May 2, 2020
Merged

Conversation

jameslahm
Copy link
Contributor

it seems index.js is useless in the store folder. On the one hand, vue-persist plugin has been added in plugin/vuex-persist.js. And the other hand, nuxt can process state.js and mutations.js correctly.

@TravisBuddy
Copy link

Hey @jameslahm,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a200e970-8bbd-11ea-83cf-d10851dce6c4

@TravisBuddy
Copy link

Hey @jameslahm,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f9026bb0-8c4c-11ea-bf8a-61073f267ac6

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be redundant, just need to ensure things work as expected.

@liyasthomas liyasthomas merged commit 44cff35 into hoppscotch:master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants