URL Path Parameters #834 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sboulema, TravisBuddy Request Identifier: 9435b390-8d32-11ea-bfcd-ab7027f5d872 |
|
Hey @sboulema, TravisBuddy Request Identifier: ab681df0-8d32-11ea-bfcd-ab7027f5d872 |
liyasthomas
added
feature
|
@sboulema I can't reproduce this PR's intended behaviour on the deploy preview: https://deploy-preview-840--postwoman.netlify.app/ Environment variables added from parameters list with |
|
Wow sorry it only worked in a couple of scenarios. Updated the PR works much more reliably now! |
|
Hey @sboulema, TravisBuddy Request Identifier: 1e5d2420-8eca-11ea-80eb-6b769f7cd14d |
|
Hey @sboulema, TravisBuddy Request Identifier: dda2b840-8ef2-11ea-80eb-6b769f7cd14d |
liyasthomas
approved these changes
May 5, 2020
|
Looks like this was merged but I don't see it in the UI. Has it moved or changed? Or is setting runtime environment variables via pre-request scripts still the preferred way of implementing URL path parameters? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a type dropdown to the current parameter list. Based on the type, the parameter either gets included as a query parameter or gets added as an environment variable so it can be used in the current url path template replacement.
Parameters without a type are treated as query parameters so the implementation is backwards-compatible.
This way the parameter gets saved with the request and does not have to be saved with the environment.