Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing environment variables via Postman environment json files #862

Merged
merged 2 commits into from
May 11, 2020

Conversation

sboulema
Copy link
Contributor

When importing a JSON file during the environment import we check for the Postman specific field _postman_variable_scope which should be set to environment.

If so, we re-format the JSON to the Postwoman structure and call the existing import function.
If not, we assume it is a Postwoman file and import it as usual.

This PR intends to add the feature discussed in #759

@TravisBuddy
Copy link

Hey @sboulema,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f20c0fa0-9368-11ea-84cf-61c3ab5f248b

@TravisBuddy
Copy link

Hey @sboulema,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f8fc0810-9368-11ea-84cf-61c3ab5f248b

@liyasthomas
Copy link
Member

liyasthomas commented May 11, 2020

@sboulema Welcome to Postwoman collaborators team 💚
You've now earned much more control over PW repo. You can review PRs, assign issues, create branches and other perks of a collaborator. Pinky promise that you merge a PR with at least one accepted review from any of the collaborators. If you agree, kindly accept the invitation here: https://github.com/liyasthomas/postwoman/invitations

We've a Telegram group and Discord server to discuss about the project. Find its link from readme. Ping me for any doubts.

@liyasthomas liyasthomas self-requested a review May 11, 2020 09:34
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sboulema sboulema self-assigned this May 11, 2020
@sboulema sboulema added the feature New feature or request label May 11, 2020
@liyasthomas liyasthomas merged commit f88158e into hoppscotch:master May 11, 2020
@sboulema sboulema deleted the feature/#759 branch May 11, 2020 10:00
@sboulema
Copy link
Contributor Author

Thanks for the invitation! Accepted of course, proud to be a part of the team 😄

@liyasthomas
Copy link
Member

@all-contributors please add @sboulema for code

@allcontributors
Copy link
Contributor

@liyasthomas

I've put up a pull request to add @sboulema! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow importing environment variables via Postman environment json files
3 participants