refactor: add support for new abstractions at the workspace level #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com> Co-authored-by: amk-dev <akash.k.mohan98@gmail.com>
jamesgeorge007
force-pushed
the
workspace-refactor-changes
branch
from
3786603
to
bbddfce
Compare
nivedin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings about changes to support the new abstractions at the workspace level that are in the works - hoppscotch/hoppscotch#3836.
rootNodes&childNodesinTree&TreeBranchcomponents are no longer computed properties. Since a handle-based system is introduced which leverages reactivity greatly, this is necessary to prevent any UI freeze while switching between workspaces.keyprop while rendering theSmartTreeBranchcomponent within the same component to include node data type and ID. This ensures the UI stays consistent with the underlying state changes and necessary rerenders get triggered.getChildrenmethodnodeType(need not be supplied for root nodes, hence optional) to distinguish between the incoming node types. This helps tree adapter implementations avoid performing operations specific to collections in case the incoming node is a request.Closes HFE-506.