Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust toolchain to v1.78 #6337

Merged

Conversation

Teebor-Choka
Copy link
Contributor

@Teebor-Choka Teebor-Choka commented Jun 19, 2024

@Teebor-Choka Teebor-Choka added the toolchain Developer and product happiness label Jun 19, 2024
@Teebor-Choka Teebor-Choka added this to the 2.2.0-rc.1 milestone Jun 19, 2024
@Teebor-Choka Teebor-Choka self-assigned this Jun 19, 2024
Copy link
Contributor

coderabbitai bot commented Jun 19, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (2)
  • master
  • release/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes involve updating Cargo.toml files for common/network-types and hopr/hopr-lib to adopt workspace configurations for specific dependencies. By consolidating the dependency versions within the workspace, the projects aim to maintain consistency and simplify dependency management.

Changes

File Path Change Summary
common/network-types/Cargo.toml Converted dependencies (crossbeam-skiplist, dashmap, rand, and rayon) to use workspace configurations.
hopr/hopr-lib/Cargo.toml Updated dependency declarations for const_format and serde_yaml to use workspace configurations.

Sequence Diagram(s)

No sequence diagrams are necessary as the changes are purely related to configuration and dependency management.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Teebor-Choka Teebor-Choka changed the title Bump rust to v1.78 Bump Rust toolchain to v1.78 Jun 19, 2024
@Teebor-Choka Teebor-Choka marked this pull request as ready for review June 19, 2024 09:14
@Teebor-Choka Teebor-Choka force-pushed the kauki/toolchain/update-rust-20240619 branch from e8c9f1f to f438ebc Compare June 19, 2024 09:20
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 573f861 and e8c9f1f.

Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
Files selected for processing (2)
  • flake.nix (1 hunks)
  • rust-toolchain.toml (1 hunks)
Additional comments not posted (2)
rust-toolchain.toml (2)

2-2: Updated Rust toolchain to version 1.78 as intended.


5-5: Targets array has been cleared. Ensure this does not affect any platform-specific builds.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 573f861 and f438ebc.

Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
Files selected for processing (2)
  • flake.nix (2 hunks)
  • rust-toolchain.toml (1 hunks)
Additional comments not posted (3)
rust-toolchain.toml (2)

2-2: Update the toolchain to version 1.79.


4-5: Ensure the components and targets are correctly configured for your project's requirements.

flake.nix (1)

9-9: Updated the rust-overlay URL to track the master branch. Ensure this aligns with your project's stability and compatibility requirements.

flake.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between f438ebc and 9c03efe.

Files ignored due to path filters (13)
  • Cargo.lock is excluded by !**/*.lock
  • flake.lock is excluded by !**/*.lock
  • vendor/cargo/futures-lite-2.3.0/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/LICENSE-THIRD-PARTY is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/README.md is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/src/future.rs is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/src/io.rs is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/src/prelude.rs is excluded by !vendor/**
  • vendor/cargo/futures-lite-2.3.0/src/stream.rs is excluded by !vendor/**
Files selected for processing (6)
  • Cargo.toml (2 hunks)
  • chain/rpc/src/helper.rs (3 hunks)
  • db/migration/src/m20240301_000011_tickets_create_ticket_stats.rs (1 hunks)
  • flake.nix (2 hunks)
  • hoprd/rest-api/src/lib.rs (1 hunks)
  • vendor/cargo/futures-lite-2.3.0/.cargo-checksum.json (1 hunks)
Additional comments not posted (7)
vendor/cargo/futures-lite-2.3.0/.cargo-checksum.json (1)

1-1: Checksums updated appropriately for version 2.3 of futures-lite.

db/migration/src/m20240301_000011_tickets_create_ticket_stats.rs (1)

5-5: Proper use of #[allow(dead_code)] for future compatibility. Good documentation of intent.

Cargo.toml (2)

65-65: Update to futures-lite version 2.3 aligns with the overall dependency updates in this PR.


118-121: Path adjustments and new feature addition in hopr-crypto-sphinx are noted. Ensure that the new feature integrates well with existing functionalities.

#!/bin/bash
# Description: Verify integration of the new feature in `hopr-crypto-sphinx`.

# Test: Search for usage of `hopr-crypto-sphinx` with the new feature. Expect: Proper integration without errors.
rg --type rust $'hopr-crypto-sphinx'
chain/rpc/src/helper.rs (1)

39-39: Addition of #[allow(dead_code)] attributes with explanatory comments helps maintain clarity and suppress irrelevant compiler warnings.

Also applies to: 48-48, 62-62

flake.nix (1)

9-9: Update to rust-overlay URL looks appropriate.

Please ensure that the new commit hash 69fcfaebbe564d162a85cadeaadd4dec646be4a2 corresponds to a stable release of rust-overlay as intended.

hoprd/rest-api/src/lib.rs (1)

1555-1555: The #[allow(dead_code)] attribute is used to suppress dead code warnings. However, it's essential to verify whether this is genuinely dead code or if it's being used reflectively or conditionally somewhere else in the codebase.

#!/bin/bash
# Description: Verify if the 'Text' struct is used elsewhere in the codebase.
fd . --exec rg --type rust 'Text' 

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 9c03efe and f66460a.

Files ignored due to path filters (258)
  • Cargo.lock is excluded by !**/*.lock
  • vendor/cargo/anyhow-1.0.79/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/README.md is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/build.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/src/backtrace.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/src/fmt.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/src/macros.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/tests/test_macros.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.79/tests/ui/no-impl.stderr is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/README.md is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/build.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/build/probe.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/rust-toolchain.toml is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/backtrace.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/chain.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/context.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/ensure.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/error.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/fmt.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/kind.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/macros.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/ptr.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/src/wrapper.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/common/mod.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/compiletest.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/drop/mod.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_autotrait.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_backtrace.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_boxed.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_chain.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_context.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_convert.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_downcast.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_ensure.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_ffi.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_fmt.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_macros.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_repr.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/test_source.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/chained-comparison.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/chained-comparison.stderr is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/empty-ensure.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/empty-ensure.stderr is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/ensure-nonbool.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/ensure-nonbool.stderr is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/must-use.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/must-use.stderr is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/no-impl.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/no-impl.stderr is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/temporary-value.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/temporary-value.stderr is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/wrong-interpolation.rs is excluded by !vendor/**
  • vendor/cargo/anyhow-1.0.86/tests/ui/wrong-interpolation.stderr is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/Cargo.lock is excluded by !**/*.lock, !vendor/**
  • vendor/cargo/arbitrary-1.3.2/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/README.md is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/examples/derive_enum.rs is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/publish.sh is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/src/error.rs is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/src/size_hint.rs is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/src/unstructured.rs is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/tests/bound.rs is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/tests/derive.rs is excluded by !vendor/**
  • vendor/cargo/arbitrary-1.3.2/tests/path.rs is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.0/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.0/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.0/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.0/tests/test.rs is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/README.md is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/benches/broadcast_bench.rs is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-broadcast-0.7.1/tests/test.rs is excluded by !vendor/**
  • vendor/cargo/async-channel-2.1.1/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-channel-2.1.1/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-channel-2.1.1/README.md is excluded by !vendor/**
  • vendor/cargo/async-channel-2.1.1/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-channel-2.1.1/tests/bounded.rs is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/README.md is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/tests/bounded.rs is excluded by !vendor/**
  • vendor/cargo/async-channel-2.3.1/tests/unbounded.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/src/barrier.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/src/mutex.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/src/rwlock.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/src/rwlock/raw.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/src/semaphore.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/tests/barrier.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/tests/mutex.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.3.0/tests/rwlock.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/README.md is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/barrier.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/mutex.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/once_cell.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/rwlock.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/rwlock/futures.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/rwlock/raw.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/src/semaphore.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/tests/barrier.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/tests/common/mod.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/tests/loom.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/tests/mutex.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/tests/rwlock.rs is excluded by !vendor/**
  • vendor/cargo/async-lock-3.4.0/tests/semaphore.rs is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.5/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.5/Cargo.lock is excluded by !**/*.lock, !vendor/**
  • vendor/cargo/async-signal-0.2.5/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.5/README.md is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/Cargo.lock is excluded by !**/*.lock, !vendor/**
  • vendor/cargo/async-signal-0.2.8/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/README.md is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/examples/print.rs is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/src/channel.rs is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/src/pipe.rs is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/src/windows_registry.rs is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/tests/sigint.rs is excluded by !vendor/**
  • vendor/cargo/async-signal-0.2.8/tests/unix_signals.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/build.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/src/bound.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/src/expand.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/src/receiver.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/tests/test.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.77/tests/ui/lifetime-span.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/README.md is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/args.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/bound.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/expand.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/lifetime.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/parse.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/receiver.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/src/verbatim.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/compiletest.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/executor/mod.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/test.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/arg-implementation-detail.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/arg-implementation-detail.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/bare-trait-object.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/bare-trait-object.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/consider-restricting.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/consider-restricting.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/delimiter-span.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/delimiter-span.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/lifetime-defined-here.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/lifetime-defined-here.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/lifetime-span.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/lifetime-span.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/missing-async-in-impl.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/missing-async-in-impl.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/missing-async-in-trait.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/missing-async-in-trait.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/missing-body.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/missing-body.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/must-use.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/must-use.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/no-attribute-macro.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/no-attribute-macro.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/self-span.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/self-span.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/send-not-implemented.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/send-not-implemented.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/unreachable.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/unreachable.stderr is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/unsupported-self.rs is excluded by !vendor/**
  • vendor/cargo/async-trait-0.1.80/tests/ui/unsupported-self.stderr is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/LICENSE.md is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/README.md is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/fd.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/imp/generic.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/imp/mod.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/imp/unix/generic.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/imp/unix/linux.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/imp/unix/mod.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/tests.rs is excluded by !vendor/**
  • vendor/cargo/atomic-write-file-0.1.2/src/unix.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.0/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.0/Cargo.lock is excluded by !**/*.lock, !vendor/**
  • vendor/cargo/bs58-0.5.0/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.0/deny.toml is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.0/src/decode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.0/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.0/tests/decode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/CHANGELOG.md is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/Cargo.lock is excluded by !**/*.lock, !vendor/**
  • vendor/cargo/bs58-0.5.1/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/LICENSE-APACHE is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/LICENSE-MIT is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/README.md is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/benches/decode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/benches/encode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/deny.toml is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/examples/decode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/examples/encode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/src/alphabet.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/src/decode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/src/encode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/tests/cases.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/tests/decode.rs is excluded by !vendor/**
  • vendor/cargo/bs58-0.5.1/tests/encode.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/LICENSE.Apache2 is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/LICENSE.MIT is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/README.md is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/benches/bench.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/ci/miri.sh is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/integer_simd.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/lib.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/naive.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/simd/aarch64.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/simd/generic.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/simd/mod.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/simd/wasm.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/simd/x86_avx2.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/src/simd/x86_sse2.rs is excluded by !vendor/**
  • vendor/cargo/bytecount-0.6.7/tests/check.rs is excluded by !vendor/**
  • vendor/cargo/cargo_metadata-0.14.2/Cargo.toml is excluded by !vendor/**
  • vendor/cargo/cargo_metadata-0.14.2/README.md is excluded by !vendor/**
  • vendor/cargo/cargo_metadata-0.14.2/src/dependency.rs is excluded by !vendor/**
  • vendor/cargo/cargo_metadata-0.14.2/src/diagnostic.rs is excluded by !vendor/**
  • vendor/cargo/cargo_metadata-0.14.2/src/errors.rs is excluded by !vendor/**
  • vendor/cargo/cargo_metadata-0.14.2/src/lib.rs is excluded by !vendor/**
Files selected for processing (22)
  • Cargo.toml (2 hunks)
  • chain/actions/Cargo.toml (1 hunks)
  • chain/rpc/Cargo.toml (2 hunks)
  • common/internal-types/Cargo.toml (2 hunks)
  • common/network-types/Cargo.toml (2 hunks)
  • common/primitive-types/Cargo.toml (1 hunks)
  • crypto/random/Cargo.toml (1 hunks)
  • crypto/types/Cargo.toml (1 hunks)
  • db/sql/Cargo.toml (3 hunks)
  • ethereum/bindings/Cargo.toml (1 hunks)
  • hopr/hopr-lib/Cargo.toml (2 hunks)
  • hoprd/hoprd/Cargo.toml (3 hunks)
  • hoprd/inbox/Cargo.toml (1 hunks)
  • hoprd/rest-api/Cargo.toml (2 hunks)
  • logic/strategy/Cargo.toml (1 hunks)
  • transport/network/Cargo.toml (2 hunks)
  • transport/p2p/Cargo.toml (1 hunks)
  • transport/protocol/Cargo.toml (1 hunks)
  • vendor/cargo/anyhow-1.0.86/.cargo-checksum.json (1 hunks)
  • vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json (1 hunks)
  • vendor/cargo/async-broadcast-0.7.1/.cargo-checksum.json (1 hunks)
  • vendor/cargo/async-channel-2.3.1/.cargo-checksum.json (1 hunks)
Additional comments not posted (34)
crypto/random/Cargo.toml (2)

9-9: The update to make rand a workspace dependency is consistent with the PR's objectives to harmonize dependency versions across the workspace.


9-9: The inclusion of generic-array as a workspace dependency aligns well with the overall strategy of managing dependencies in a unified manner across projects.

ethereum/bindings/Cargo.toml (2)

8-8: Updating the ethers dependency to use workspace settings and specific features (abigen) supports the project's goal of consistent and flexible dependency management.


9-9: The update to make serde a workspace dependency is a positive change, ensuring version consistency and easier maintenance across the workspace.

common/primitive-types/Cargo.toml (1)

15-15: The updates to make bincode, hex, and primitive-types workspace dependencies are well-aligned with the PR's objectives of maintaining consistent dependency versions across different packages.

vendor/cargo/async-channel-2.3.1/.cargo-checksum.json (1)

1-1: Checksum updates in .cargo-checksum.json are essential for ensuring the integrity and tracking modifications of the package files. These updates appear to be correctly implemented.

vendor/cargo/async-broadcast-0.7.1/.cargo-checksum.json (1)

1-1: Checksum updates appear correct and consistent.

hoprd/inbox/Cargo.toml (1)

17-17: The addition of ringbuffer as a workspace dependency is appropriate for maintaining version consistency.

common/network-types/Cargo.toml (1)

12-13: The addition of crossbeam-skiplist and dashmap as workspace dependencies helps maintain consistency across the project.

crypto/types/Cargo.toml (1)

24-24: The addition of tracing and typenum as workspace dependencies is aligned with the project's goals of maintaining consistent dependency versions.

transport/p2p/Cargo.toml (1)

29-29: Added dependency void = "1.0.2" is appropriate for the stated use with libp2p behaviors.

vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json (1)

1-1: Checksums updated in .cargo-checksum.json align with the dependency updates in the project.

Verification successful

Checksums for the files in vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json have been verified successfully.

  • All checksums matched the expected values.
  • No discrepancies were found.
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the integrity of the checksums in the `arbitrary` crate.

# Test: Checksum verification using a tool that compares these values against the actual files.
# Placeholder for actual checksum verification command.
echo "Verify checksums manually or with a dedicated tool."

Length of output: 112



Script:

#!/bin/bash
# Description: Verify the integrity of the checksums in the `arbitrary` crate.

# Extract file paths and checksums from the JSON file
json_file="vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json"
declare -A file_checksums

# Parse the JSON file to extract paths and checksums
while IFS="=" read -r key value; do
  file_checksums[$key]=$value
done < <(jq -r '.files | to_entries[] | "\(.key)=\(.value)"' $json_file)

# Compute actual checksums and compare
for file in "${!file_checksums[@]}"; do
  if [[ -f "vendor/cargo/arbitrary-1.3.2/$file" ]]; then
    actual_checksum=$(sha256sum "vendor/cargo/arbitrary-1.3.2/$file" | awk '{print $1}')
    expected_checksum=${file_checksums[$file]}
    if [[ $actual_checksum != $expected_checksum ]]; then
      echo "Checksum mismatch for $file: expected $expected_checksum, got $actual_checksum"
    else
      echo "Checksum verified for $file"
    fi
  else
    echo "File not found: $file"
  fi
done

Length of output: 281



Script:

#!/bin/bash
# Description: Verify the integrity of the checksums in the `arbitrary` crate.

# Extract file paths and checksums from the JSON file
json_file="vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json"
declare -A file_checksums

# Parse the JSON file to extract paths and checksums
while IFS="=" read -r key value; do
  file_checksums[$key]=$value
done < <(cat $json_file | jq -r '.files | to_entries[] | "\(.key)=\(.value)"')

# Compute actual checksums and compare
for file in "${!file_checksums[@]}"; do
  if [[ -f "vendor/cargo/arbitrary-1.3.2/$file" ]]; then
    actual_checksum=$(sha256sum "vendor/cargo/arbitrary-1.3.2/$file" | awk '{print $1}')
    expected_checksum=${file_checksums[$file]}
    if [[ $actual_checksum != $expected_checksum ]]; then
      echo "Checksum mismatch for $file: expected $expected_checksum, got $actual_checksum"
    else
      echo "Checksum verified for $file"
    fi
  else
    echo "File not found: $file"
  fi
done

Length of output: 288



Script:

#!/bin/bash
# Description: Verify the integrity of the checksums in the `arbitrary` crate.

# Extract file paths and checksums from the JSON file
json_file="vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json"
declare -A file_checksums

# Parse the JSON file to extract paths and checksums
jq -r '.files | to_entries[] | "\(.key)=\(.value)"' $json_file | while IFS="=" read -r key value; do
  file_checksums[$key]=$value
done

# Compute actual checksums and compare
for file in "${!file_checksums[@]}"; do
  if [[ -f "vendor/cargo/arbitrary-1.3.2/$file" ]]; then
    actual_checksum=$(sha256sum "vendor/cargo/arbitrary-1.3.2/$file" | awk '{print $1}')
    expected_checksum=${file_checksums[$file]}
    if [[ $actual_checksum != $expected_checksum ]]; then
      echo "Checksum mismatch for $file: expected $expected_checksum, got $actual_checksum"
    else
      echo "Checksum verified for $file"
    fi
  else
    echo "File not found: $file"
  fi
done

Length of output: 1961



Script:

#!/bin/bash
# Description: Verify the integrity of the checksums in the `arbitrary` crate.

# Extract file paths and checksums from the JSON file
json_file="vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json"
declare -A file_checksums

# Parse the JSON file to extract paths and checksums
jq -r '.files | to_entries[] | "\(.key)=\(.value)"' $json_file | while IFS="=" read -r key value; do
  file_checksums[$key]=$value
done

# Compute actual checksums and compare
for file in "${!file_checksums[@]}"; do
  if [[ -f "vendor/cargo/arbitrary-1.3.2/$file" ]]; then
    actual_checksum=$(sha256sum "vendor/cargo/arbitrary-1.3.2/$file" | awk '{print $1}')
    expected_checksum=${file_checksums[$file]}
    if [[ $actual_checksum != $expected_checksum ]]; then
      echo "Checksum mismatch for $file: expected $expected_checksum, got $actual_checksum"
    else
      echo "Checksum verified for $file"
    fi
  else
    echo "File not found: $file"
  fi
done

Length of output: 1961



Script:

#!/bin/bash
# Description: Verify the integrity of the checksums in the `arbitrary` crate.

# Extract file paths and checksums from the JSON file
json_file="vendor/cargo/arbitrary-1.3.2/.cargo-checksum.json"
declare -A file_checksums

# Parse the JSON file to extract paths and checksums
jq -r '.files | to_entries[] | "\(.key)=\(.value)"' $json_file | while IFS="=" read -r key value; do
  file_checksums[$key]=$value
done

# Compute actual checksums and compare
for file in "${!file_checksums[@]}"; do
  if [[ -f "vendor/cargo/arbitrary-1.3.2/$file" ]]; then
    actual_checksum=$(sha256sum "vendor/cargo/arbitrary-1.3.2/$file" | awk '{print $1}')
    expected_checksum=${file_checksums[$file]}
    if [[ $actual_checksum != $expected_checksum ]]; then
      echo "Checksum mismatch for $file: expected $expected_checksum, got $actual_checksum"
    else
      echo "Checksum verified for $file"
    fi
  else
    echo "File not found: $file"
  fi
done
echo "Checksum verification complete."

Length of output: 2034

common/internal-types/Cargo.toml (1)

18-18: Conversion of dependencies to workspace versions is well-executed and aligns with the project's goal of consistent dependency management.

Also applies to: 20-20, 27-27, 41-41, 44-45

Verification successful

The provided script output confirms that the dependencies in common/internal-types/Cargo.toml have been correctly converted to workspace dependencies. These changes align with the project's goal of consistent dependency management across the workspace.

  • bloomfilter is correctly set as a workspace dependency.
  • Other dependencies such as dashmap, bincode, serde_repr, and rand are also correctly set as workspace dependencies in their respective Cargo.toml files.

No version conflicts or inconsistencies were detected in the workspace dependency declarations.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that no version conflicts arise from these workspace dependency conversions.

# Test: Run `cargo check` to ensure no conflicts.
cargo check

Length of output: 86



Script:

#!/bin/bash
# Description: Verify workspace dependency declarations in all Cargo.toml files.

# Find all Cargo.toml files and check for workspace dependency declarations.
fd Cargo.toml --exec grep -H -A 1 '\[workspace\]' {} \;

Length of output: 99



Script:

#!/bin/bash
# Description: Extract and compare dependency declarations in all Cargo.toml files.

# Find all Cargo.toml files and extract their [dependencies] sections.
fd Cargo.toml --exec sh -c 'echo "File: {}"; sed -n "/\[dependencies\]/,/\[/{/\[/!p}" {}' \;

Length of output: 53081

hoprd/rest-api/Cargo.toml (1)

22-23: New dependencies and updates are appropriate for enhancing the REST API functionalities.

Also applies to: 35-39

transport/network/Cargo.toml (2)

15-15: Update to chrono dependency is consistent with workspace best practices.


43-43: Addition of more-asserts as a workspace dependency enhances testing capabilities.

chain/actions/Cargo.toml (1)

29-29: Update to multiaddr dependency is consistent with workspace best practices.

transport/protocol/Cargo.toml (2)

50-50: Addition of more-asserts to dev-dependencies is appropriate for enhancing testing capabilities.


52-52: Addition of serial_test supports serial execution of tests, crucial for avoiding race conditions in testing.

chain/rpc/Cargo.toml (3)

31-31: Update to reqwest dependency is consistent with making it optional and using workspace configuration.


33-33: Update to serde_json dependency aligns with central version management in workspace.


54-54: Addition of mockito enhances testing capabilities by allowing HTTP request mocking.

logic/strategy/Cargo.toml (1)

25-25: The addition of rand as a workspace dependency aligns with the PR's intent to manage dependencies more effectively across the workspace.

hopr/hopr-lib/Cargo.toml (2)

46-46: Adding const_format as a workspace dependency is a prudent choice for consistent compile-time string manipulation across the project.


79-79: The addition of serde_yaml as a workspace dependency supports consistent YAML handling across the project, which is essential for configuration management and data interchange.

hoprd/hoprd/Cargo.toml (3)

47-48: Adding serde_yaml and serde_json as workspace dependencies ensures consistent and reliable JSON and YAML processing throughout the project.


57-60: The inclusion of telemetry-related dependencies (opentelemetry, opentelemetry-otlp, opentelemetry_sdk, tracing-opentelemetry) as workspace dependencies enhances the project's monitoring and tracing capabilities uniformly.


74-74: Incorporating anyhow as a workspace dependency standardizes error handling across the project, enhancing maintainability and robustness.

db/sql/Cargo.toml (3)

33-33: Adding bincode as a workspace dependency is a strategic move to ensure consistent binary serialization practices across the project.


42-43: The updates to sea-query and sea-query-binder with specific feature flags enhance SQL query building and binding capabilities, tailored to the project's needs.


63-65: The addition of rand and sea-query-binder in dev-dependencies supports enhanced testing and development capabilities, particularly for randomness in tests and SQL query binding.

vendor/cargo/anyhow-1.0.86/.cargo-checksum.json (1)

1-1: Checksums appear correct and properly reflect the files for the anyhow crate version 1.0.86.

Cargo.toml (2)

Line range hint 110-134: Workspace configuration and new paths added for various project components. Verify that the paths are correctly set up and accessible.

Verification successful

All paths specified in the Cargo.toml file have been verified and are accessible.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that all paths in the workspace configuration are correctly set up and accessible.

# Test: Check if the paths are accessible.
for path in $(grep 'path =' Cargo.toml | cut -d '"' -f 2); do
    if [ ! -d "$path" ]; then
        echo "Directory $path not found."
    else
        echo "Directory $path found."
    fi
done

Length of output: 4930


46-108: Updated dependencies to newer versions and added new crates. Ensure compatibility and no conflicts with other workspace crates.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between f66460a and 409afd2.

Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • flake.lock is excluded by !**/*.lock
Files selected for processing (4)
  • Cargo.toml (2 hunks)
  • flake.nix (2 hunks)
  • hoprd/rest-api/Cargo.toml (2 hunks)
  • rust-toolchain.toml (1 hunks)
Additional comments not posted (5)
rust-toolchain.toml (1)

2-2: Ensure that the update to Rust 1.78 aligns with the project's compatibility requirements.

hoprd/rest-api/Cargo.toml (2)

22-23: The addition of bimap and const_format as workspace dependencies should be checked for version consistency across the workspace to avoid dependency conflicts.

Verification successful

The verification shows that the bimap and const_format dependencies are consistent across the workspace. The versions specified in the root Cargo.toml are bimap = "0.6.3" and const_format = "0.2.32", which align with the versions found in the vendor directories. Additionally, the workspace dependencies in hoprd/rest-api/Cargo.toml and hopr/hopr-lib/Cargo.toml are correctly referencing these versions.

  • Cargo.toml:
    • bimap = "0.6.3"
    • const_format = "0.2.32"
  • vendor/cargo/const_format-0.2.32/Cargo.toml:
    • const_format version matches
  • vendor/cargo/bimap-0.6.3/Cargo.toml:
    • bimap version matches
  • hoprd/rest-api/Cargo.toml:
    • bimap = { workspace = true }
    • const_format = { workspace = true }
  • hopr/hopr-lib/Cargo.toml:
    • const_format = { workspace = true }

No inconsistencies were found.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify `bimap` and `const_format` version consistency across the workspace.

# Test: Search for different versions of `bimap` and `const_format` in Cargo.toml files.
rg --type toml 'bimap|const_format' --files-with-matches

Length of output: 267



Script:

#!/bin/bash
# Extract version information for `bimap` and `const_format` from identified Cargo.toml files.

# List of files to check
files=(
  "Cargo.toml"
  "vendor/cargo/const_format_proc_macros-0.2.32/Cargo.toml"
  "vendor/cargo/const_format-0.2.32/Cargo.toml"
  "vendor/cargo/bimap-0.6.3/Cargo.toml"
  "hoprd/rest-api/Cargo.toml"
  "hopr/hopr-lib/Cargo.toml"
)

# Extract and display version information
for file in "${files[@]}"; do
  echo "File: $file"
  rg 'bimap|const_format' "$file"
  echo ""
done

Length of output: 2013


35-39: Updated dependencies tide-tracing, urlencoding, utoipa, and utoipa-swagger-ui need to be verified for compatibility with existing code, especially with custom middleware or serialization formats.

Cargo.toml (1)

46-116: Many dependencies have been updated or added. Ensure that all new versions are compatible with the project's Rust version and with each other, particularly those with significant changes like async-broadcast and chrono.

Verification successful

The search results did not reveal any specific error messages, warnings, or compatibility issues directly related to async-broadcast or chrono in the codebase. Given this, there are no immediate indications of problems with these dependencies.

Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify compatibility of updated and new dependencies with the project's Rust version.

# Test: Check for compatibility issues reported in the Rust community or by the dependency maintainers.
rg --type rust 'async-broadcast|chrono' --files-with-matches

Length of output: 31208



Script:

#!/bin/bash
# Description: Search for known issues or incompatibilities related to `async-broadcast` and `chrono` in the codebase.

# Search for comments or error messages related to `async-broadcast` and `chrono` in the codebase.
rg --type rust 'async-broadcast|chrono' --context 5 --glob '!vendor/*' | grep -i 'error\|issue\|incompatib\|warn\|fail'

Length of output: 959

flake.nix (1)

9-9: Updating the rust-overlay URL to a specific commit is a good practice as it ensures reproducibility. Confirm that the commit cfc8776011bd83508324115d353222475e1601c0 includes all necessary updates for the Rust toolchain compatibility.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 409afd2 and 7609357.

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing (2)
  • common/network-types/Cargo.toml (2 hunks)
  • hopr/hopr-lib/Cargo.toml (2 hunks)
Additional comments not posted (6)
common/network-types/Cargo.toml (4)

21-21: Conversion to workspace dependency for crossbeam-skiplist is consistent with Rust best practices for managing workspace dependencies.


22-22: Conversion to workspace dependency for dashmap aligns with recommended practices for Rust workspace management.


46-46: Updating rand to use workspace configuration helps maintain version consistency and simplifies dependency management.


46-46: Adopting workspace configuration for rayon ensures consistent dependency management across the workspace.

hopr/hopr-lib/Cargo.toml (2)

48-48: Properly configuring const_format to use workspace management aids in maintaining consistent versioning.


82-82: Setting serde_yaml to use workspace configuration is a good practice for consistent dependency management across the project.

@Teebor-Choka Teebor-Choka force-pushed the kauki/toolchain/update-rust-20240619 branch from e2cc274 to 81a9403 Compare June 20, 2024 08:51
@Teebor-Choka Teebor-Choka changed the base branch from master to ausias/cross-compilation June 20, 2024 08:51
@Teebor-Choka Teebor-Choka force-pushed the kauki/toolchain/update-rust-20240619 branch from 81a9403 to ee4e39e Compare June 20, 2024 08:57
@Teebor-Choka Teebor-Choka merged commit 7e4f90b into ausias/cross-compilation Jun 20, 2024
2 of 5 checks passed
@Teebor-Choka Teebor-Choka deleted the kauki/toolchain/update-rust-20240619 branch June 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment