allow counterparty to close channel before cool down period #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCBuergel
reviewed
Nov 23, 2020
| @@ -37,6 +37,7 @@ contract HoprChannels is IERC777Recipient, ERC1820Implementer { | |||
| * stateCounter mod 10 == 2: open | |||
| * stateCounter mod 10 == 3: pending | |||
| */ | |||
| bool closureByPartyA; // channel closure was initiated by party A | |||
| } | |||
There was a problem hiding this comment.
Here we should decrease the size of a previous entry in the struct to keep the total size of the struct to <= 64 bytes (2 words). I suggest to decrease the closureTime to uint32 which is going to be fine until Sunday, February 7, 2106 6:28:15 AM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252