-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cache behavior tests from ActiveSupport #4
Conversation
Yeah, include'ing and overriding CacheStoreBehavior seems important to have in the test suite 👍 |
You have successfully added a new CodeQL configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments... I have some thoughts on CompositeCacheStore
itself too that I'll submit separately...
Co-authored-by: Jamie McCarthy <jamie@mccarthy.vg>
Co-authored-by: Jamie McCarthy <jamie@mccarthy.vg>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, this is a big step forward 👍
Inspired by the work on #3