Skip to content

Commit

Permalink
Comment skipped tests because appmapp sees them as failed (#131)
Browse files Browse the repository at this point in the history
  • Loading branch information
@hopsoft
hopsoft committed Mar 1, 2024
1 parent 9434239 commit a81cfc4
Show file tree
Hide file tree
Showing 2 changed files with 72 additions and 72 deletions.
72 changes: 36 additions & 36 deletions test/system/basic_commands/reset_frame_test.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,51 +9,51 @@ def accept_dialod(dialog)
dialog.accept
end

test "increment once then reset and accept confirm" do
skip "Playwright dialog handling not working yet"
page.goto basic_command_url
user = User.last
# test "increment once then reset and accept confirm" do
# skip "Playwright dialog handling not working yet"
# page.goto basic_command_url
# user = User.last

assert_equal 0, user.count
assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 0, user.count
# assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text

trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
trigger.click
wait_for_detach trigger
# trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 1, user.reload.count
assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 1, user.reload.count
# assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text

page.on :dialog, ->(dialog) { dialog.accept }
trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
trigger.click
wait_for_detach trigger
# page.on :dialog, ->(dialog) { dialog.accept }
# trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 0, user.reload.count
assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text
end
# assert_equal 0, user.reload.count
# assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text
# end

test "increment once then reset and dismiss confirm" do
skip "Playwright dialog handling not working yet"
page.goto basic_command_url
user = User.last
# test "increment once then reset and dismiss confirm" do
# skip "Playwright dialog handling not working yet"
# page.goto basic_command_url
# user = User.last

assert_equal 0, user.count
assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 0, user.count
# assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text

trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
trigger.click
wait_for_detach trigger
# trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 1, user.reload.count
assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 1, user.reload.count
# assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text

page.on :dialog, ->(dialog) { dialog.accept }
trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
trigger.click
wait_for_detach trigger
# page.on :dialog, ->(dialog) { dialog.accept }
# trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 1, user.reload.count
assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
end
# assert_equal 1, user.reload.count
# assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
# end
end
72 changes: 36 additions & 36 deletions test/system/basic_commands/reset_no_frame_test.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,51 +5,51 @@
class ResetNoFrameTest < ApplicationSystemTestCase
PARENT_SELECTOR = "#basic_command-no-frame"

test "increment once then reset and accept confirm" do
skip "Playwright dialog handling not working yet"
page.goto basic_command_url
user = User.last
# test "increment once then reset and accept confirm" do
# skip "Playwright dialog handling not working yet"
# page.goto basic_command_url
# user = User.last

assert_equal 0, user.count
assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 0, user.count
# assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text

trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
trigger.click
wait_for_detach trigger
# trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 1, user.reload.count
assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 1, user.reload.count
# assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text

page.on :dialog, ->(dialog) { dialog.accept }
trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
trigger.click
wait_for_detach trigger
# page.on :dialog, ->(dialog) { dialog.accept }
# trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 2, user.reload.count
assert_equal "0002", page.wait_for_selector("code[role='counter']").inner_text
end
# assert_equal 2, user.reload.count
# assert_equal "0002", page.wait_for_selector("code[role='counter']").inner_text
# end

test "increment once then reset and dismiss confirm" do
skip "Playwright dialog handling not working yet"
page.goto basic_command_url
user = User.last
# test "increment once then reset and dismiss confirm" do
# skip "Playwright dialog handling not working yet"
# page.goto basic_command_url
# user = User.last

assert_equal 0, user.count
assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 0, user.count
# assert_equal "0000", page.wait_for_selector("code[role='counter']").inner_text

trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
trigger.click
wait_for_detach trigger
# trigger = page.wait_for_selector("[data-turbo-command='IncrementCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 1, user.reload.count
assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
# assert_equal 1, user.reload.count
# assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text

page.on :dialog, ->(dialog) { dialog.accept }
trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
trigger.click
wait_for_detach trigger
# page.on :dialog, ->(dialog) { dialog.accept }
# trigger = page.wait_for_selector("[data-turbo-command='ResetCountCommand']")
# trigger.click
# wait_for_detach trigger

assert_equal 1, user.reload.count
assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
end
# assert_equal 1, user.reload.count
# assert_equal "0001", page.wait_for_selector("code[role='counter']").inner_text
# end
end

0 comments on commit a81cfc4

Please sign in to comment.