Extract devtools to separate package #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrubisch
force-pushed
the
extract-devtools
branch
from
94d5e1b
to
b399888
Compare
julianrubisch
force-pushed
the
extract-devtools
branch
from
90b158c
to
6b6e43d
Compare
julianrubisch
force-pushed
the
extract-devtools
branch
from
a1fb8cf
to
c375a84
Compare
hopsoft
reviewed
May 1, 2023
| @@ -29,6 +29,7 @@ | |||
| "prettier-standard": "^16.4.1" | |||
| }, | |||
| "scripts": { | |||
| "build": "esbuild app/javascript/index.js --bundle --minify --sourcemap --format=esm --target=es2020,chrome58,firefox57,safari11 --analyze --outfile=app/assets/builds/@turbo-boost/elements.js" | |||
| "build": "esbuild app/javascript/index.js --bundle --minify --sourcemap --format=esm --target=es2020,chrome58,firefox57,safari11 --analyze --outfile=app/assets/builds/@turbo-boost/elements.js", | |||
| "build:watch": "yarn build -- --watch" | |||
hopsoft
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Devtool class has been extracted to the @turbo_boost/devtools package, with this library's
triggerElementjust serving as the delegate.Note that I think it would be nice to remove all references to
devtoolfromtriggerElement(such asinitializeDevtool) to a mixin living in the devtools package, but I wanted to take it one at a time.Once we release a first version of the devtools package, we can move this PR from draft to open.