Replace BaseEventLoop with AbstractEventLoop #16
Conversation
|
@freundTech Hi! Thanks for the PR - I completely missed the notification though. Before we go further, could you please include your PR description (as 72-char wide line-wrapped text) in the commit message? That would be most appreciated in order to have all necessary context for a change easily reachable from Thanks! |
freundTech
force-pushed
the
fix-abstract-event-loop-annotation
branch
from
9992a30
to
328d3bc
Compare
|
Done! I also replace the link to typeshed, as the line numbers had changed. I've now linked to a fixed revision. |
|
@freundTech Thanks! Now I can even trigger the pipeline run \o/. Could you maybe add the line wrapping to the commit message and leave blanks between the paragraphs? |
This is needed for the type annotations to work correctly with type-checkers. asyncio.get_event_loop(), asyncio.get_running_loop() and similar functions all return AbstractEventLoop, leading to a type error if one tries to pass their return value to this library. See https://github.com/python/typeshed/blob/97a74bc1aab4b18827a8861dfc310c96cc52ad55/stdlib/asyncio/events.pyi#L590
freundTech
force-pushed
the
fix-abstract-event-loop-annotation
branch
from
328d3bc
to
5dbff84
Compare
|
I updated the commit message again and fixed the mypy and lint errors (mypy was complaining about an unused # type: ignore and flake8 about a line to long in inline documentation) |
|
Thanks a lot! |
This is needed for the type annotations to work correctly with type-checkers.
asyncio.get_event_loop(), asyncio.get_running_loop() and similar functions all return AbstractEventLoop, leading to a type error if one tries to pass their return value to this library.
See https://github.com/python/typeshed/blob/master/stdlib/asyncio/events.pyi#L527