This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
muc: always emit on_presence_change on presence updates #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horazont
added
the
enhancement
sebastianriese
approved these changes
Jul 27, 2020
horazont
force-pushed
the
feature/muc-on_presence_changed-always
branch
from
e29892b
to
2f8b297
Compare
Without this, there is no simple way for users of the Room object
to obtain presence updates from occupants. While they could
install a global presence filter, that is highly undesirable.
The previous code would only emit on_presence_changed if the `show`
or `status` of the presence had changed. However, with custom
presence payloads, other attributes can be as or even more
interesting than that.
Fixes #341.
horazont
force-pushed
the
feature/muc-on_presence_changed-always
branch
from
2f8b297
to
f37fa4a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, there is no simple way for users of the Room object
to obtain presence updates from occupants. While they could
install a global presence filter, that is highly undesirable.
The previous code would only emit on_presence_changed if the
showor
statusof the presence had changed. However, with custompresence payloads, other attributes can be as or even more
interesting than that.
Fixes #341.