Controller rest request body #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed Horde_Controller currently lacks any access to the body of a http request like post or put, unless it's form-encoded. In this case, getPostVars works well For the REST usecase, I would want to post/put a json object string containing details. Another use case would be handling some bulk upload like a file (owncloudish) or a media stream. For the REST use case, just slurping stdin and returning it as a string would be sufficient. For the latter, it would be more convenient to expose the stream resource - both memory and performance wise. Horde_Stream has a __toString() to implicitly return a string where one is expected.
|
Is there anything to do here? |
|
Sorry for the delay. This looks good. Merging, thanks! |
mrubinsk
added a commit
that referenced
this pull request
Jul 4, 2018
mrubinsk
added a commit
that referenced
this pull request
Jul 4, 2018
mrubinsk
added a commit
that referenced
this pull request
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Request Body Stream to interface
I noticed Horde_Controller currently lacks any access to the body of a http request like post or put, unless it's form-encoded. In this case, getPostVars works well
For the REST usecase, I would want to post/put a json object string containing details.
Another use case would be handling some bulk upload like a file (owncloudish) or a media stream.
For the REST use case, just slurping stdin and returning it as a string would be sufficient.
For the latter, it would be more convenient to expose the stream resource - both memory and performance wise.
Horde_Stream has a __toString() to implicitly return a string where one is expected.